Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: relay jenkins and gh events to gh #272

Closed
wants to merge 4 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app.js
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ app.use(bunyanMiddleware({
}))

require('./lib/github-events')(app, events)
require('./lib/jenkins-events')(app, events)

app.use(function logUnhandledErrors (err, req, res, next) {
logger.error(err, 'Unhandled error while responding to incoming HTTP request')
Expand Down
2 changes: 1 addition & 1 deletion lib/github-client.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
'use strict'

const GitHub = require('github')
const GitHub = require('@octokit/rest')

const githubClient = new GitHub({
version: '3.0.0',
Expand Down
1 change: 1 addition & 0 deletions lib/github-events.js
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ module.exports = (app, events) => {
data.logger.info('Emitting GitHub event')
debug(data)

events.emit('github', data, org, repo, data.sender.login)
return events.emit(data.action, data, org, repo, data.sender.login)
}
}
82 changes: 82 additions & 0 deletions lib/jenkins-events.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,82 @@
'use strict'

const pushJenkinsUpdate = require('../lib/push-jenkins-update')

const debug = require('debug')('jenkins-events')
const enabledRepos = process.env.JENKINS_ENABLED_REPOS
? process.env.JENKINS_ENABLED_REPOS.split(',')
: ['citgm', 'http-parser', 'node', 'node-auto-test']

const listOfKnownJenkinsIps = process.env.JENKINS_WORKER_IPS ? process.env.JENKINS_WORKER_IPS.split(',') : []

function isKnownJenkinsIp (req) {
const ip = req.connection.remoteAddress.split(':').pop()

if (listOfKnownJenkinsIps.length && !listOfKnownJenkinsIps.includes(ip)) {
req.log.warn({ ip }, 'Ignoring, not allowed to push Jenkins updates')
return false
}

return true
}

function isRelatedToPullRequest (gitRef) {
// refs/pull/12345/head vs refs/heads/v8.x-staging/head
return gitRef.includes('/pull/')
}

module.exports = (app, events) => {
app.post('/:repo/jenkins/:event', async (req, res) => {
const isValid = pushJenkinsUpdate.validate(req.body)
const repo = req.params.repo
const event = req.params.event
const owner = req.body.owner || process.env.JENKINS_DEFAULT_GH_OWNER || 'nodejs'

if (!isValid) {
return res.status(400).end('Invalid payload')
}

if (!isRelatedToPullRequest(req.body.ref)) {
return res.status(400).end('Will only push builds related to pull requests')
}

if (!enabledRepos.includes(repo)) {
return res.status(400).end('Invalid repository')
}

if (!isKnownJenkinsIp(req)) {
return res.status(401).end('Invalid Jenkins IP')
}

const data = {
...req.body,
owner,
repo,
event
}

try {
await app.emitJenkinsEvent(event, data, req.log)
res.status(200)
} catch (err) {
req.log.error(err, 'Error while emitting Jenkins event')
res.status(500)
}

res.end()
})

app.emitJenkinsEvent = function emitJenkinsEvent (event, data, logger) {
const { identifier } = data

// create unique logger which is easily traceable throughout the entire app
// by having e.g. "nodejs/nodejs.org/#1337" part of every subsequent log statement
data.logger = logger.child({ identifier, event }, true)

data.logger.info('Emitting Jenkins event')
debug(data)

events.emit(`jenkins`, data)
return events.emit(`jenkins.${event}`, data)
}
}
Loading