jenkins: check successful response before reading #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While having a look at recent error logs, this fatal log stood out:
```
02:48:11.721 FATAL bot: Unchaught exception, terminating bot process immediately
TypeError: Cannot read property 'data' of undefined
at githubClient.pullRequests.getCommits (/.../github-bot/lib/push-jenkins-update.js:92:29)
at module.exports.sendError (/.../github-bot/node_modules/github/lib/index.js:874:7)
at /.../github-bot/node_modules/github/lib/index.js:882:21
at callCallback (/.../github-bot/node_modules/github/lib/index.js:738:9)
at IncomingMessage.<anonymous> (/.../github-bot/node_modules/github/lib/index.js:807:13)
at IncomingMessage.emit (events.js:194:15)
at endReadableNT (_stream_readable.js:1125:12)
at process._tickCallback (internal/process/next_tick.js:63:19)
```
Since we never want these kinds of errors to happen since they
end up killing the bot process, this fix is pushed to ensure we
don't naively read the response from github.com until we know the
request didn't fail for some reason.
Refs #246
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FYI PR that gets merged ASAP because of its trivialness.
While having a look at recent error logs, this fatal log stood out:
Since we never want these kinds of errors to happen since they end up killing the bot process, this fix is pushed to ensure we don't naively read the response from github.com until we know the request didn't fail for some reason.