chore: Remove @Tiriel, add @AhmadAwais to CommComm alias. #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trott
reviewed
Apr 15, 2019
iojs.org/aliases.json
Outdated
| @@ -131,7 +131,7 @@ | |||
| "agiriabrahamjunior@gmail.com", | |||
| "ahmadbamieh@gmail.com", | |||
| "ammiller@linkedin.com", | |||
| "benjamin.zaslavsky@gmail.com", | |||
| "me@AhmadAwais.com", | |||
There was a problem hiding this comment.
Nit: The email addresses are otherwise in alphabetical order, which is nice for lists that can tend to get long. Can you move this to be after Manil and before Michael to maintain alphabetical ordering?
There was a problem hiding this comment.
@amiller-gh are you going to be able to update?
There was a problem hiding this comment.
🙏 sorry, pseudo-vacation. Updated.
Trott
approved these changes
Apr 15, 2019
|
@amiller-gh best not to merge these yourself because the update process has to be run by one of us with mailgun keys so it's not automatic. In future maybe just ping myself and Michael when it's ready to be deployed and we'll merge as part of the deploy. |
|
oh, and yes I've deployed these changes |
|
Ah, good to know! Thanks for getting it rolled out anyway 👍
…On Apr 29, 2019, 6:56 PM -0700, Rod Vagg ***@***.***>, wrote:
oh, and yes I've deployed these changes
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.