Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sort email alphabetically #101

Closed
wants to merge 1 commit into from
Closed

sort email alphabetically #101

wants to merge 1 commit into from

Conversation

WaleedAshraf
Copy link
Contributor

This was easy.
❤️ lodash

screen shot 2018-05-26 at 3 09 30 am

@WaleedAshraf WaleedAshraf mentioned this pull request May 25, 2018
Closed
@WaleedAshraf
Copy link
Contributor Author

One and only change other than sorting is making these to array.

Before:

 {
    "from": "rvagg",
    "to": "rod@vagg.org"
  },
  {
    "from": "jbergstroem",
    "to": "bugs@bergstroem.nu"
  }

After:

 {
    "from": "rvagg",
    "to": ["rod@vagg.org"]
  },
  {
    "from": "jbergstroem",
    "to": ["bugs@bergstroem.nu"]
  }

mhdawson

This comment was marked as off-topic.

Sign in to view

keywordnew

This comment was marked as off-topic.

Sign in to view

mhdawson pushed a commit that referenced this pull request May 29, 2018
@WaleedAshraf @mhdawson
sort email alphabetically
ef6832c 
PR-URL: #101
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Chowdhurian <manil.chowdhury@gmail.com>
@mhdawson
Copy link
Member

Landed as ef6832c

@mhdawson mhdawson closed this May 29, 2018
@WaleedAshraf WaleedAshraf deleted the sort-emails branch May 29, 2018 19:55
Johnhvy pushed a commit to Johnhvy/NodeJS-Email that referenced this pull request Jul 16, 2024
@WaleedAshraf @Johnhvy
sort email alphabetically
1c1bf55 
PR-URL: nodejs/email#101
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Chowdhurian <manil.chowdhury@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson approved these changes

@keywordnew keywordnew keywordnew approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@WaleedAshraf @mhdawson @keywordnew