Skip to content
This repository has been archived by the owner on Apr 16, 2020. It is now read-only.

Commit

Permalink
fixup: impl remove try/catch
Browse files Browse the repository at this point in the history
  • Loading branch information
MylesBorins authored and nodejs-ci committed Mar 21, 2019
1 parent 13aab7f commit eb6a03f
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions src/module_wrap.cc
Original file line number Diff line number Diff line change
Expand Up @@ -903,17 +903,13 @@ void ModuleWrap::Resolve(const FunctionCallbackInfo<Value>& args) {
env, "second argument is not a URL string");
}

TryCatchScope try_catch(env);
Maybe<URL> result =
node::loader::Resolve(env,
specifier_std,
url);
if (result.IsNothing()) {
CHECK(try_catch.HasCaught());
try_catch.ReThrow();
return;
}
CHECK(!try_catch.HasCaught());

URL resolution = result.FromJust();
CHECK(!(resolution.flags() & URL_FLAGS_FAILED));
Expand Down

0 comments on commit eb6a03f

Please sign in to comment.