Temporarily revert Alpine build ccache implement #932
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chorrell
approved these changes
Nov 22, 2018
|
Thanks, this probably wasn't an easy PR to put together. Fortunately we have a record in git of the changes so we can revisit this again after the security update. |
tianon
reviewed
Nov 22, 2018
| @@ -40,19 +39,13 @@ RUN addgroup -g 1000 node \ | |||
| && grep " node-v$NODE_VERSION.tar.xz\$" SHASUMS256.txt | sha256sum -c - \ | |||
| && tar -xf "node-v$NODE_VERSION.tar.xz" \ | |||
| && cd "node-v$NODE_VERSION" \ | |||
| && ln -s /usr/bin/ccache /usr/local/bin/cc \ | |||
| && ln -s /usr/bin/ccache /usr/local/bin/gcc \ | |||
| && ln -s /usr/bin/ccache /usr/local/bin/g++ \ | |||
| && HOST_IP="$(ip route | awk '/default/ { print $3 }')" \ | |||
| && nc -v "$HOST_IP" 5678 | tar -xz -C / || true \ | |||
There was a problem hiding this comment.
These are the most problematic bits (nc to the host machine IP is really hacky), so I'd recommend including them in this revert.
There was a problem hiding this comment.
Used git revert to create a more direct "revert" alternative at #933 to try and help this get in for the security release next week. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc #918 #923 #927