Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Drop Node 9 #803

Merged
merged 1 commit into from
Jul 1, 2018
Merged

build: Drop Node 9 #803

merged 1 commit into from
Jul 1, 2018

Conversation

nschonni
Copy link
Member

@nschonni nschonni commented Jul 1, 2018

chorrell

This comment was marked as off-topic.

@SimenB SimenB merged commit b22fb6c into nodejs:master Jul 1, 2018
@nschonni nschonni deleted the drop-9 branch July 1, 2018 17:49
@nschonni
Copy link
Member Author

nschonni commented Jul 2, 2018

PS: @LaurentGoderre this didn't trigger a official-images PR

@LaurentGoderre
Copy link
Member

It wouldn't since the version no longer appears as a valid version. I guess it's a limitation of the detection we use currently

@nschonni
Copy link
Member Author

nschonni commented Jul 3, 2018

Actually, I guess it doesn't matter since it just means the diff will get calculated next time there is actually a functional change. The PR would really just update to the file in official images to drop the 9, but the other hashes would be the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants