Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Node.js 20.18.0 #2142

Closed
wants to merge 1 commit into from
Closed

feat: Node.js 20.18.0 #2142

wants to merge 1 commit into from

Conversation

nodejs-github-bot
Copy link
Collaborator

Automated changes by create-pull-request GitHub action

@nodejs-github-bot nodejs-github-bot requested a review from a team October 3, 2024 19:48
@LaurentGoderre
Copy link
Member

This PR isn't ideal because it changes other versions without any version bump

nschonni
nschonni requested changes Oct 3, 2024
View reviewed changes
Copy link
Member

@nschonni nschonni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with Laurent, will need to do manual PRs for the updates till each release line has a release to change the keys again

@nodejs-github-bot nodejs-github-bot requested a review from a team October 3, 2024 21:04
@nschonni nschonni mentioned this pull request Oct 4, 2024
Merged
@SimenB
Copy link
Member

SimenB commented Oct 4, 2024

We really should update the script to only update if there is a version change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nschonni nschonni nschonni requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nodejs-github-bot @LaurentGoderre @SimenB @nschonni