Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Hide auto-generated files in code reviews and format Dockerfile templates" #2070

Merged
merged 2 commits into from
May 11, 2024

Conversation

nschonni
Copy link
Member

Reverts #2062

This means we need to click the "load diff" everywhere in the UI including the Commit view to see the actual changes. These files may be auto-generated in some cases, but we we need to verify the changes visually to ensure there are no intentional or unintentional malicious changes.

@nschonni nschonni merged commit 8402bb4 into main May 11, 2024
1 check passed
@nschonni nschonni deleted the revert-2062-hide-auto-generated branch May 11, 2024 18:01
@PeterDaveHello
Copy link
Member

This is definitely why we should make the PR and commit clean so that it'll be much more easier to trace, revert, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants