Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up /tmp folder to save about 2.2MB of space #2049

Merged
merged 1 commit into from
Apr 13, 2024

Conversation

mohamedelhabib
Copy link
Contributor

Description

The /tmp folder contains a folder v8-compile-cache-0 2.2Mo

Motivation and Context

optimise the docker image version

Testing Details

tested locally to confirm the image size

Example Output(if appropriate)

Types of changes

  • Documentation
  • Version change (Update, remove or add more Node.js versions)
  • Variant change (Update, remove or add more variants, or versions of variants)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (none of the above)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING.md document.
  • All new and existing tests passed.

Copy link
Member

@PeterDaveHello PeterDaveHello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we need to do the same thing for non-Alpine images?

@mohamedelhabib
Copy link
Contributor Author

@PeterDaveHello done

@PeterDaveHello PeterDaveHello changed the title cleanup the /tmp folder to save 2.2Mo Clean up /tmp folder to save about 2.2MB of space Apr 13, 2024
@PeterDaveHello PeterDaveHello merged commit 17bf083 into nodejs:main Apr 13, 2024
25 checks passed
Copy link

Created PR on the official-images repo (docker-library/official-images#16604). See https://github.com/docker-library/faq#an-images-source-changed-in-git-now-what if you are wondering when it will be available on the Docker Hub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants