chore: Add check for missing Alpine CHECKSUM #1317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nschonni
force-pushed
the
missing-checksum
branch
from
d281299 to
83c32bf
Compare
nschonni
commented
Aug 21, 2020
10/alpine3.10/Dockerfile
Outdated
| @@ -12,7 +12,7 @@ RUN addgroup -g 1000 node \ | |||
| && case "${alpineArch##*-}" in \ | |||
| x86_64) \ | |||
| ARCH='x64' \ | |||
| CHECKSUM="2afa21473a5eb8f407c52fe3bf08180630f3ac9541d52b98e99dbf4fe79f82d2" \ | |||
| CHECKSUM="" \ | |||
There was a problem hiding this comment.
Here for testing, undo before landing
10/alpine3.9/Dockerfile
Outdated
| @@ -12,7 +12,7 @@ RUN addgroup -g 1000 node \ | |||
| && case "${alpineArch##*-}" in \ | |||
| x86_64) \ | |||
| ARCH='x64' \ | |||
| CHECKSUM="2afa21473a5eb8f407c52fe3bf08180630f3ac9541d52b98e99dbf4fe79f82d2" \ | |||
| CHECKSUM="" \ | |||
There was a problem hiding this comment.
Here for testing, undo before landing
| if [ "$(find -path *alpine*/Dockerfile -exec grep -l CHECKSUM=\"\" {} \; | wc -l)" == 0 ]; then | ||
| exit 0 | ||
| else | ||
| # echo "::error file=FILENAME,line=15,col=22::Missing pre-built checksum" |
There was a problem hiding this comment.
This echo should set comments directly on the affected lines if the right filenames are printed. I've hardcoded the 15 and 22 line/col based off the templates
|
Thoughts on just throwing (exiting with an error?) in the update script instead? |
12 tasks
MasonM
reviewed
Oct 13, 2021
nschonni
force-pushed
the
missing-checksum
branch
3 times, most recently
from
a2aa52a to
1f002d6
Compare
Co-authored-by: Mason Malone <mason.malone@gmail.com>
nschonni
force-pushed
the
missing-checksum
branch
from
1f002d6 to
73f32c4
Compare
|
Rebasing off the test commit, but it looks good |
nschonni
force-pushed
the
missing-checksum
branch
from
f66b5b9 to
73f32c4
Compare
SimenB
approved these changes
Oct 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basic check works, but it would be better if the error can be set on the line in the affected file https://docs.github.com/en/actions/reference/workflow-commands-for-github-actions#setting-an-error-message
Opening as a draft so someone better at bash can suggest something to pipe the
findresult in a better manner, or just to loop over the grep results