feat: Node v13.11.0 and Yarn 1.22.4 #1229
Conversation
nschonni
force-pushed
the
node-13.11.0-yarn-1.22.4
branch
from
dfa96ac to
a95e58c
Compare
| @@ -74,9 +74,6 @@ for version in "${versions[@]}"; do | |||
| tag=$(get_tag "${version}") | |||
| full_version=$(get_full_version "${version}") | |||
|
|
|||
| build "${version}" "default" "${tag}" | |||
| test_image "${full_version}" "default" "${tag}" | |||
There was a problem hiding this comment.
My Chakracore fix in the other PR was incorrect in removing just the if and leaving the contents. It should have removed these lines, so when I pushed the original PR, the build failed on the tests.
There was a problem hiding this comment.
It's actually a little clearer on my GH Actions PR #1194 where all the builds failed before doing the same fix
There was a problem hiding this comment.
Let's separate the fix to another PR, it has nothing to do with the version update itself.
There was a problem hiding this comment.
Not sure if the fix commit is for the build https://travis-ci.com/github/nodejs/docker-node/builds/152927756 which was failed originally, I restarted the builds and the all passed now.
|
Hey, is there any chance this will be merged soon ? |
|
I cannot merge this since it has a requested change. @PeterDaveHello @nschonni can you update?
|
|
The unrelated commit should be separated, I'll help do that. |
|
See #1233 |
There is currently an issue with the nodejs.org website webhook, but the release post has landed