Skip to content

fix(globals): add ErrorEvent and TypedArray #416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

avivkeller
Copy link
Member

These are missing from our list of globals (I didn't realize globals.builtin didn't include them in 0ecb11e)

@avivkeller avivkeller requested a review from a team as a code owner August 22, 2025 23:37
Copy link

vercel bot commented Aug 22, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
api-docs-tooling Ready Ready Preview Aug 22, 2025 11:41pm

Copy link

codecov bot commented Aug 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.78%. Comparing base (02d53de) to head (b697579).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #416      +/-   ##
==========================================
- Coverage   74.22%   71.78%   -2.45%     
==========================================
  Files         118       96      -22     
  Lines       10994     9370    -1624     
  Branches      696      578     -118     
==========================================
- Hits         8160     6726    -1434     
+ Misses       2831     2642     -189     
+ Partials        3        2       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ovflowd
Copy link
Member

ovflowd commented Aug 23, 2025

@avivkeller build failed?

@avivkeller
Copy link
Member Author

@avivkeller build failed?

It's unrelated. It was the bug that #414 fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants