Skip to content
This repository has been archived by the owner on Apr 18, 2018. It is now read-only.

Deprecation Policy #49

Closed
jasnell opened this issue Apr 10, 2015 · 5 comments
Closed

Deprecation Policy #49

jasnell opened this issue Apr 10, 2015 · 5 comments

Comments

@jasnell
Copy link
Member

jasnell commented Apr 10, 2015

The dev-policy currently does not include anything about the deprecation process. If we're going to cover reversions, we ought to cover deprecations also.

@mikeal
Copy link

mikeal commented Apr 10, 2015

This also came up in the last TC meeting. My recollection of what we said was:

  • Mark API as deprecated in the docs. Wait a full major cycle before taking any further action.
  • Consider printing a dep warning. Wait a full major cycle before taking any further action.
  • Consider removal.

In some (possibly most) cases we won't make it past the first step and it's possible we never make it to the third.

@chrisdickinson
Copy link

@domenic also suggested having a "pending-deprecation" state that coincides with the "mark API deprecated" step for folks to proactively seek out deprecations ahead of time, which I'm in favor of.

@Fishrock123
Copy link
Contributor

Something that isn't too complex.

2-3 steps might be ok as @mikeal said.

  • Deprecate in docs if it was documented (+Major cycle)
  • util.deprecate (skip to here if was undocumented) (+Major cycle)
  • consider removing

@mhdawson
Copy link
Member

Just wondering why the gap between deprecating in the docs and the util.deprecate. Along the same lines as Chris's comment above I'd like it to be easy to pro-actively identify deprecated methods automatically as soon as possible.

Once its in the docs I can see it helping people to stop using it but have we seen people quickly remove it from their existing code once only the docs are updated ?

@thefourtheye
Copy link

What is the official word on this? I feel that the doc and deprecation notice can land together in a major and the removal can happen in the next major bump.

thefourtheye added a commit to thefourtheye/io.js that referenced this issue Aug 22, 2015
This patch documentes the deprecation of util.is* functions.
[Official deprecation policy](nodejs/dev-policy/issues/49) states that,
we need to start with documenting the deprecation first. So, this is
the first step towards officially removing them.
thefourtheye added a commit to nodejs/node that referenced this issue Aug 24, 2015
This patch documentes the deprecation of util.is* functions.
As per the deprecation policy dicussion, nodejs/dev-policy/issues/49,
we need to start with documenting the deprecation. So, this is
the first step towards officially removing them.

PR-URL: #2447
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@jasnell jasnell closed this as completed Mar 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants