Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: add cache validation #82

Merged
merged 3 commits into from
Jan 23, 2022
Merged

ci: add cache validation #82

merged 3 commits into from
Jan 23, 2022

Conversation

merceyz
Copy link
Member

@merceyz merceyz commented Jan 23, 2022

What's the problem this PR addresses?

Some of the entires in .yarn/cache has the wrong checksum and there isn't a CI check to prevent that from happening.

How did you fix it?

Updated the checksums and added cache validation to the CI.

arcanis
arcanis approved these changes Jan 23, 2022
View reviewed changes
Copy link
Contributor

@arcanis arcanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just checked the versions currently in cache, the only changes are the timestamp ones when we switched Yarn's normalized time from 1980 to 1984; files have the same content before and after 👍

@arcanis arcanis merged commit 4344ba1 into nodejs:main Jan 23, 2022
@merceyz merceyz deleted the merceyz/ci/cache-check branch January 23, 2022 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arcanis arcanis arcanis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@merceyz @arcanis