package: add git hook instructions #13

srl295 · 2016-10-27T20:56:30Z

Add instructions and a hook to call core-validate-commit from
git commits.

Depends on #11

Known issues:

leaves ${TMPF} around (temporary file)
probably will reject fixup: type commit logs
may be too strict if someone is just doing a simple
'work in progress' kind of local branch

Larger improvement:

fold the entire hook script into a mode, and/or an alternate
script entrypoint into core-validate-commit. This would drop
requirements on sh, sed, grep…

Fixes: #12

Add instructions and a hook to call core-validate-commit from git commits. Depends on nodejs#11 Known issues: - leaves ${TMPF} around (temporary file) - probably will reject `fixup:` type commit logs - may be too strict if someone is just doing a simple 'work in progress' kind of local branch Larger improvement: - fold the entire hook script into a mode, and/or an alternate script entrypoint into core-validate-commit. This would drop requirements on sh, sed, grep… Fixes: nodejs#12

This was referenced Oct 27, 2016

bin: allow file:/// urls to files containing commit messages #11

Open

doc: update collaborator_guide to mention core-validate-commit nodejs/node#9328

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

package: add git hook instructions #13

package: add git hook instructions #13

srl295 commented Oct 27, 2016

package: add git hook instructions #13

Are you sure you want to change the base?

package: add git hook instructions #13

Conversation

srl295 commented Oct 27, 2016