Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update lookup dec 2019 #773

Merged
merged 3 commits into from
Dec 17, 2019
Merged

Update lookup dec 2019 #773

merged 3 commits into from
Dec 17, 2019

Conversation

MylesBorins
Copy link
Contributor

  • Skip zeromq
    • cmake not on buildbots
  • skip node-gyp
    • new test fails on new releases
  • set commander as flaky
    • timeouts on our infra

@MylesBorins
lookup: skip zeromq
bbf9ee4 
* currently requires cmake
@MylesBorins
lookup: skip node-gyp
49c5e62 
the current test suite will always fail on a new release
@MylesBorins
lookup: set commander as flaky
4603831 
Seems to keep failing with timeouts across build bots
@MylesBorins MylesBorins merged commit e0e64c0 into nodejs:master Dec 17, 2019
@BridgeAR
Copy link
Member

Refs: tj/commander.js#1123
Refs: zeromq/zeromq.js#376
Refs: nodejs/node-gyp#2000

@BridgeAR
Copy link
Member

Refs: nodejs/build#2097

@BridgeAR
Copy link
Member

Commander is fixed and should work again as soon as they publish a new release.

@shadowspawn shadowspawn mentioned this pull request Nov 2, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MylesBorins @BridgeAR