Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lookup: unskip ws on win32 #607

Merged
merged 1 commit into from
May 14, 2019
Merged

Conversation

lpinca
Copy link
Member

@lpinca lpinca commented Oct 5, 2018

Unskip ws on Windows.

Checklist
  • contribution guidelines followed here

@lpinca
Copy link
Member Author

lpinca commented Oct 5, 2018

@lpinca
Copy link
Member Author

lpinca commented Oct 5, 2018

It seems citgm-smoker-nobuild does not work. Trying with citgm-smoker.

CI: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1569/

@lpinca
Copy link
Member Author

lpinca commented Nov 25, 2018

@nodejs/citgm Is there anything I can do to move this and #608 forward?

@targos
Copy link
Member

targos commented Nov 25, 2018

Results are good on Node 10 and 11 but the job fails to run on 6 and 8 (opened nodejs/build#1602)

@targos
Copy link
Member

targos commented Nov 25, 2018

@MylesBorins
Copy link
Contributor

hey @lpinca the pipeine job you tried to run was running for almost 10 hours so I aborted it. Lets dig in and figure out what was taking so long. I think it is that the AIX machine is out of memory

/cc @nodejs/build

@lpinca
Copy link
Member Author

lpinca commented Nov 29, 2018

Ok, there is also something wrong in the Windows machines.

09:24:52 verbose: ws npm:             | Using temp directory: "c:workspacecitgm-smoker-nobuild\citgm_tmp\11e0389e-843f-4c19-bf2c-57dcf7e39917\npm_config_tmp"
09:24:53 info: ws npm:             | npm install successfully completed
09:24:53 info: ws npm:             | test suite started  
09:24:53 verbose: ws npm-test:        | 'node' is not recognized as an internal or external command,
09:24:53 verbose:                     | operable program or batch file.                             
09:24:53 error: failure             | The canary is dead:

@codecov-io
Copy link

codecov-io commented Dec 14, 2018

Codecov Report

Merging #607 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #607   +/-   ##
=======================================
  Coverage   94.52%   94.52%           
=======================================
  Files          27       27           
  Lines         876      876           
=======================================
  Hits          828      828           
  Misses         48       48

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46e3809...4dfda8a. Read the comment docs.

Copy link
Member

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is green

@targos
Copy link
Member

targos commented May 14, 2019

@targos targos merged commit 278a6d3 into nodejs:master May 14, 2019
@lpinca lpinca deleted the unskip/ws-on-windows branch May 14, 2019 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants