lib: introduce a timeout to npm test

[refack]

Fixes: #426

Checklist

• npm test passes
• tests are included
• documentation is changed or added
• contribution guidelines followed here

[refack]

My first code contribution to CITGM for your reviewing pleasure.

Should this be addition be documented?

[refack]

Do you CI on Jenkins?
https://ci.nodejs.org/view/Node.js-citgm/job/citgm-continuous-integration/29/

[refack]

Thanks for abstracting timout. Would you be able to squash the commits and add tests for the timeout function

Ack.

[refack]

Delinted.

[gibfahn]

CI: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-continuous-integration-pipeline/52/
Smoker: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker-nobuild/157/

[refack]

@gibfahn land?
Ref: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/894/nodes=osx1010/console

[refack]

CI looks good (almost perfect), PTAL

[refack]

Ping: timeouts are a PITA (they clog the CI 😞) https://ci.nodejs.org/job/citgm-smoker/nodes=osx1010/897/

Rerun CITGM CI: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-continuous-integration/30/

[refack]

Is it's just me or is the CI actually red (with master)?

[gibfahn]

@refack yep, CI is red on master

[MylesBorins]

When did this happen? Is there pr that broke it or is it just a platform regression?

…

On Jul 6, 2017 1:13 PM, "Gibson Fahnestock" ***@***.***> wrote: @refack <https://github.com/refack> yep, CI is red on master — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#441 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAecVweSFRHd-4GrcSSIu9YEUvrbg6qWks5sLMFBgaJpZM4N48I9> .

[targos]

Anyone with a mac can reproduce?

[MylesBorins]

This may be due to new osx maxhines in ci. I can check in a short bit

…

On Jul 6, 2017 1:57 PM, "Michaël Zasso" ***@***.***> wrote: Anyone with a mac can reproduce? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#441 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAecV-0ObeoqNVsMsiMYj0sxSHUgnvQFks5sLMu1gaJpZM4N48I9> .

[refack]

It's red across the board:

https://ci.nodejs.org/view/Node.js-citgm/job/citgm-continuous-integration/31/ (I excluded osx1010 just for resource conservation)

AFAICT it's an npm related timeout.

[targos]

It's red across the board

Oh sorry, I looked at the results from an earlier run (the 4 failing checks that GitHub shows)

[targos]

npm 5 broke the tests. Fix: #447

[MylesBorins]

Fix landed, can you rebase and re run CI please

…

On Thu, Jul 6, 2017 at 4:01 PM, Michaël Zasso ***@***.***> wrote: npm 5 broke the tests. Fix: #447 <#447> — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#441 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAecV-5i2SzuPK_y_D4I0fUFXMyV-Y21ks5sLOirgaJpZM4N48I9> .

[refack]

Jenkins: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-continuous-integration/34/

[MylesBorins]

@refack can you look into why travis is failing?

https://travis-ci.org/nodejs/citgm/jobs/250825074

[refack]

Just making sure, that variation is node 6 on macOS?

[MylesBorins]

yup It is failing with a timeout, which made me think it might be relevant

…

On Jul 10, 2017, at 11:47 AM, Refael Ackermann ***@***.***> wrote: Just making sure, that variation is node 6 on macOS? <https://user-images.githubusercontent.com/96947/28014696-a871f714-653b-11e7-99a8-0e69af5c63fb.png> — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#441 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAecV-5qwuEVlrJEsKLrl7v8JRH3NAJWks5sMgFSgaJpZM4N48I9>.

[MylesBorins]

landed in 77b1cd6 release in 2.0.6

If there are issues we can revisit

[refack]

Ohh, I'll recheck 6/macOS