lookup: add "native" tag for native modules

[gibfahn]

Fixes: #377

• npm test passes
• contribution guidelines followed here
• commit message follows commit guidelines

cc/ @richardlau

[gibfahn]

@gdams We should build on 7.7.0 with --exclude-tag native and make sure it's green.

[gdams]

@gdams We should build on 7.7.0 with --exclude-tag native and make sure it's green.

https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/619/

[MylesBorins]

it is worth mentioning that the way we do testing of native module 7.7.0 will still pass. this is something we should explore separately, specifically building using that header compiled with make rather than the source tree

[gibfahn]

@MylesBorins I meant that we should run https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker-nobuild (which was previously called https://ci.nodejs.org/view/Node.js-citgm/job/gibfahn-citgm-smoker-more-platforms). That job fetches from nodejs.org, so it should pick up the failures (I hope).

[gdams]

https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker-nobuild/127/

[richardlau]

That job fetches from nodejs.org, so it should pick up the failures (I hope).

Not if run with --exclude-tag native 😄

[gibfahn]

@richardlau Yeah, --exclude-tag native should all pass, --include-tag native should all fail...

[gdams]

So level failed on ppcle & ppcbe but nothing else.

This is because it has a dependency on leveldown, which is a native module, but downloads prebuilt binaries for most platform.

[gdams]

lets get #292 landed and then you can add the native tags to those modules too

[gibfahn]

I think we need to think about whether a native module that uses node-pre-gyp to download binaries is a native module. Obviously it technically is, but from the point of view of CitGM maybe we need two categories, maybe native-build and native-download (although that'd be platform specific so difficult to do).

Alternately we could just make sure we specify the --build-from-source flag (or the npm config variable) and try to force everything to build from source. We could even try to disable the network while that part of the install is happening.

[gibfahn]

@gdams updated

[gdams]

@nodejs/citgm can we get some reviews please

[gibfahn]

@MylesBorins you okay with me landing this?

[gibfahn]

Backported to v1.x in 2b2e00a