Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bin: allow testing subsystems #308

Merged
merged 1 commit into from
Mar 1, 2017
Merged

bin: allow testing subsystems #308

merged 1 commit into from
Mar 1, 2017

Conversation

gdams
Copy link
Member

@gdams gdams commented Jan 9, 2017 •
edited
Loading

this PR adds the functionality to run citgm-all on specific tags in
the lookup by passing in the includeTags or excludeTags option.
fixes #72

@gdams gdams added this to the v2.0.0 milestone Jan 9, 2017
@gdams gdams force-pushed the subsystems branch 2 times, most recently from d026be7 to 327b08a Compare January 9, 2017 11:05
gibfahn

This comment was marked as off-topic.

Sign in to view

@gdams gdams force-pushed the subsystems branch 7 times, most recently from d25595d to 0618fab Compare January 10, 2017 15:32
gibfahn

This comment was marked as off-topic.

Sign in to view

@gdams gdams requested a review from MylesBorins January 13, 2017 09:40
MylesBorins

This comment was marked as off-topic.

Sign in to view

@gdams
Copy link
Member Author

gdams commented Jan 18, 2017

@MylesBorins
we already have tests for include/exclude: https://github.com/gdams/citgm/blob/f87bb014327be7322d4c5efe5a22a2e5966b5bc3/test/bin/test-citgm-all.js#L119-L139

@gdams gdams force-pushed the subsystems branch 6 times, most recently from edbf72f to b2491fd Compare February 7, 2017 20:39
@gdams
Copy link
Member Author

gdams commented Feb 7, 2017 •
edited
Loading

@nodejs/citgm PTAL

gibfahn

This comment was marked as off-topic.

Sign in to view

@gdams gdams force-pushed the subsystems branch 2 times, most recently from a9c028a to b3ded44 Compare February 8, 2017 13:00
@gdams
Copy link
Member Author

gdams commented Feb 8, 2017

@gibfahn @MylesBorins I have now updated so that you can pass multiple tags using citgm --withTags tag1,tag2,tag3 and have also included some tests

gibfahn

This comment was marked as off-topic.

Sign in to view

@gdams gdams force-pushed the subsystems branch 3 times, most recently from 465596f to 48d3f70 Compare February 27, 2017 22:58
@gdams
Copy link
Member Author

gdams commented Feb 28, 2017

okay so I have changed withTags to includeTags

@targos targos self-assigned this Feb 28, 2017
targos

This comment was marked as off-topic.

Sign in to view

gibfahn

This comment was marked as off-topic.

Sign in to view

@gdams gdams force-pushed the subsystems branch 2 times, most recently from 0865bea to 70c35fb Compare February 28, 2017 16:27
@gdams
Copy link
Member Author

gdams commented Feb 28, 2017

@targos @gibfahn UPDATED PTAL, this also includes tests for every use case discussed above

targos

This comment was marked as off-topic.

Sign in to view

MylesBorins

This comment was marked as off-topic.

Sign in to view

MylesBorins

This comment was marked as off-topic.

Sign in to view

@gdams gdams force-pushed the subsystems branch 2 times, most recently from b6b77d1 to 96b056a Compare February 28, 2017 19:55
gibfahn

This comment was marked as off-topic.

Sign in to view

MylesBorins

This comment was marked as off-topic.

Sign in to view

MylesBorins

This comment was marked as off-topic.

Sign in to view

@gdams
Copy link
Member Author

gdams commented Mar 1, 2017

all tests passed apart from OSX which we are having issues with

bin: allow testing subsystems
b6ecb1d 
this PR adds the functionality to run `citgm-all` on specific tags in
the lookup by passing in the `includeTags` or `excludeTags` option.
fixes nodejs#72
@gdams gdams merged commit b6ecb1d into nodejs:master Mar 1, 2017
@gdams gdams deleted the subsystems branch March 1, 2017 20:26
@gibfahn gibfahn mentioned this pull request Mar 1, 2017
Closed
@targos targos removed their assignment Oct 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzoz bzoz bzoz approved these changes

@gibfahn gibfahn gibfahn approved these changes

@targos targos targos approved these changes

@MylesBorins MylesBorins MylesBorins approved these changes

Assignees
No one assigned
Labels
do not land enhancement semver-minor
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.

Allow testing subsystems
5 participants
@gdams @gibfahn @MylesBorins @targos @bzoz