Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Packer support for MacOS 13 release images in Orka #3893

Merged
merged 5 commits into from
Sep 9, 2024
Merged

Add Packer support for MacOS 13 release images in Orka #3893

merged 5 commits into from
Sep 9, 2024

Conversation

UlisesGascon
Copy link
Member

@UlisesGascon UlisesGascon commented Sep 7, 2024 •
edited
Loading

Main Changes

  • Added new Orka templated for release images. They are very similar to the tests machines (see: Add Packer support for MacOS 13 test images in Orka #3882)
  • New environmental variables added (included ci and documentation)
  • CI is now selective on what variables are passed based on the image name, to avoid validation errors.

Context

@UlisesGascon UlisesGascon changed the title WIP Add Packer support for MacOS 13 release images in Orka Sep 7, 2024
@UlisesGascon UlisesGascon self-assigned this Sep 7, 2024
@UlisesGascon UlisesGascon requested a review from a team September 7, 2024 16:38
@UlisesGascon UlisesGascon marked this pull request as ready for review September 7, 2024 16:39
@UlisesGascon

This comment was marked as outdated.

Sign in to view
mhdawson
mhdawson approved these changes Sep 9, 2024
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson mhdawson merged commit 205146b into nodejs:main Sep 9, 2024
2 checks passed
@UlisesGascon UlisesGascon deleted the feat/packer-release-image-build branch September 9, 2024 15:27
@UlisesGascon UlisesGascon mentioned this pull request Sep 16, 2024
Open
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson approved these changes

Assignees

@UlisesGascon UlisesGascon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@UlisesGascon @mhdawson