Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial support for Packer in Orka #3872

Merged
merged 6 commits into from
Aug 27, 2024

Conversation

UlisesGascon
Copy link
Member

@UlisesGascon UlisesGascon commented Aug 25, 2024

Main Changes

The main goal is to add support for Packer in Orka and validate the templates in future PRs.

Details

  • Add git rules to ignore .env files in orka/ folder and subfolders
  • Add the first Packer template to validate the workfow
  • Add a GH pipeline to validate any change done in the templates (exclusively)
  • Add basic documentation for using Packer with Orka

Screenshots

The template is working good enough for what is expected in this PR (communication, creation and CI validation)

Screenshot from 2024-08-25 15-37-46

Screenshot from 2024-08-25 16-09-40

Context

This PR is part of the Orka plan described in #3686 (comment)

Notes

The CI passed including the new pipeline execution details

The CI won't handle the image publication, just the validation when we do changes in the templates. All the deployment will remain manually done by the infra admins (as usual).

@UlisesGascon UlisesGascon marked this pull request as ready for review August 25, 2024 14:04
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit of a RSLGTM, but overall seems reasonable to me.

@UlisesGascon UlisesGascon merged commit b008503 into nodejs:main Aug 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants