-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jenkins,doc: remove support for building addons with VS2017 #3603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is necessary for C++20 compat. Refs: nodejs/node#45427
richardlau
approved these changes
Jan 3, 2024
mhdawson
approved these changes
Jan 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
UlisesGascon
approved these changes
Jan 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
MoLow
approved these changes
Jan 4, 2024
StefanStojanovic
approved these changes
Jan 8, 2024
StefanStojanovic
added a commit
to JaneaSystems/node-gyp
that referenced
this pull request
Jan 15, 2024
Drop VS2017 support for Node.js v22 and above. Refs: nodejs/build#3603 Refs: nodejs/node#45427
StefanStojanovic
added a commit
to JaneaSystems/node-gyp
that referenced
this pull request
Jan 15, 2024
Drop VS2017 support for Node.js v22 and above. Refs: nodejs/build#3603 Refs: nodejs/node#45427
2 tasks
StefanStojanovic
added a commit
to JaneaSystems/node-gyp
that referenced
this pull request
Jan 16, 2024
Drop VS2017 support for Node.js v22 and above. Refs: nodejs/build#3603 Refs: nodejs/node#45427
StefanStojanovic
added a commit
to JaneaSystems/node-gyp
that referenced
this pull request
Jan 30, 2024
Drop VS2017 support for Node.js v22 and above. Refs: nodejs/build#3603 Refs: nodejs/node#45427
StefanStojanovic
added a commit
to JaneaSystems/node-gyp
that referenced
this pull request
Feb 1, 2024
Drop VS2017 support for Node.js v22 and above. Refs: nodejs/build#3603 Refs: nodejs/node#45427
StefanStojanovic
added a commit
to JaneaSystems/node-gyp
that referenced
this pull request
Feb 10, 2024
Drop VS2017 support for Node.js v22 and above. Refs: nodejs/build#3603 Refs: nodejs/node#45427
StefanStojanovic
added a commit
to nodejs/node-gyp
that referenced
this pull request
Mar 6, 2024
Drop VS2017 support for Node.js v22 and above. Refs: nodejs/build#3603 Refs: nodejs/node#45427
lukekarrys
pushed a commit
to nodejs/node-gyp
that referenced
this pull request
Dec 2, 2024
Drop VS2017 support for Node.js v22 and above. Refs: nodejs/build#3603 Refs: nodejs/node#45427
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary for C++20 compat.
Refs: nodejs/node#45427