Access to build resources for people outside of build group - strawman for discussion #354
Conversation
|
@nodejs/build any comments ? |
|
Not yet, will try and take a look soon @mhdawson, just a bit snowed under atm. Also, fwiw, your PR subject, description and the commit details all say that it's a "strawman for discussion" but not about what, I had to go to the actual changes to figure out what this was even about. Basic details that appear in GH notifications would be nice to help with prioritisation. |
mhdawson
changed the title
| mis-behaving to their employer ? Would being banned from involvement | ||
| in the Node.js community negatively affect them personally in some other | ||
| way ? | ||
| * Are there collaborators who work with the individual and can vouge for |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
Left a few minor comments. It also needs a reworded commit message. |
mhdawson
force-pushed
the
noncollab
branch
2 times, most recently
from
35cd287 to
d77c39f
Compare
Document process for allowing non-build team members access to build machines when necessary.
|
Updated to address @orangemocha's commends |
|
LGTM |
1 similar comment
|
LGTM |
|
|
||
| There are a number of cases were we would like to provide access to | ||
| community machines and or jenkins jobs to people who are not part | ||
| of the build working group. Examples include: |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
| them. | ||
|
|
||
| The build team will review such requests through an issue on the repo. | ||
| Once agreed the individual will be granted access through the secrets repo |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
Lots of nits but mostly LGTM! |
|
added commit to address @jbergstroem comments, incorporate all except for limiting use cases to collaborators only as I think we've left the door open to non-collaborators in some of the cases covered (with more precautions such as re-imaging etc.) |
|
@jbergstroem let me know if you have any other comments otherwise I'll plan to land early next week. |
|
@mhdawson nah looks good lets get it in. |
Document process for allowing non-build team members access to build machines when necessary. PR-URL: #354 Reviewed-By: Johan Bergstroem <johan@bergstroem.nu> Reviewed-By: Alexis Campailla <alexis@janeasystems.com> Reviewed-By: João Reis <reis@janeasystems.com>
|
Landed as 0936e41 |
As discussed in last build working group meeting. Initial
strawman for discussion