Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: only production dependencies and omit funding and audit checks #3429

Merged
merged 1 commit into from
Jul 19, 2023

Conversation

ovflowd
Copy link
Member

@ovflowd ovflowd commented Jul 19, 2023

This PR omits the installation of devDependencies at all since we don't need them for a successful build. The CI on nodejs.org uses the same arguments (In case a PR breaks these, the CI checks on nodejs.org would prevent this from being deployed).

We also removed the funding and audit checks as they're not required during this webhook.

@ovflowd ovflowd requested a review from targos July 19, 2023 08:57
@ovflowd
Copy link
Member Author

ovflowd commented Jul 19, 2023

cc @nodejs/build

Copy link
Member

@targos targos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deployed and verified it works.

@targos targos merged commit 19f6c6c into main Jul 19, 2023
4 checks passed
@targos targos deleted the chore-omit-dev-no-funding-no-audit branch July 19, 2023 09:42
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants