redirect for Windows Environment wiki page #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
yes, I think remove the first one though, let the direct go through from http to https and we'll always just link to the https version when we refer to it publicly anyway |
|
+1 to https only. Redirects like these will stay in a config forever; the less rules the better |
joaocgreis
force-pushed
the
joaocgreis-FCN-windows-installer-link
branch
from
c55dbdc to
0f89f0b
Compare
|
Thanks, updated |
|
LGTM |
Redirect pointing to the wiki page, to be used by the Windows installer. Ref: nodejs/node#4111 PR-URL: nodejs#286 Reviewed-By: Alexis Campailla <alexis@janeasystems.com>
joaocgreis
force-pushed
the
joaocgreis-FCN-windows-installer-link
branch
from
0f89f0b to
9079242
Compare
|
@rvagg what more needs to be done here to update the server config? |
|
Sorry! Someone with access to the web server just needed to drop this in /etc/nginx/sites-available/ and reload nginx. I've done that now, https://nodejs.org/windows-environment is active. |
|
Thanks! |
|
@joaocgreis (you should have access with the infra key) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary to land nodejs/node#4111
@rvagg is this the correct way to add the redirect?