jenkins: add centos7-release-sources to select-compiler.sh #2672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `centos7-release-sources` part of the `iojs+release` job builds the `node` binary and should select the compiler to use based on the Node.js version being built. Put this logic in `select-compiler.sh` (as is done for other platforms).
AshCripps
approved these changes
Jun 10, 2021
rvagg
approved these changes
Jun 10, 2021
|
Job was updated to use the select-compiler.sh script |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
centos7-release-sourcespart of theiojs+releasejob buildsthe
nodebinary and should select the compiler to use based on theNode.js version being built. Put this logic in
select-compiler.sh(as is done for other platforms).
Refs: #2671
Refs: #2481
I'll also need to update the CI job to call
select-compiler.sh(currently it directly enables devtoolset-6).