Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ansible: update Node.js from 12.x -> 14.x #2514

Merged
merged 3 commits into from
Feb 15, 2021
Merged

ansible: update Node.js from 12.x -> 14.x #2514

merged 3 commits into from
Feb 15, 2021

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Jan 7, 2021

Fixes: #2504

/cc @richardlau

@richardlau
Copy link
Member

I've run this against test-packetnet-ubuntu1804-x64-1 but unfortunately while it has added the Node.js 14 repo from Node Source it hasn't actually updated the installed Node.js to 14.x. It did update to 12.20.1 so I'm presuming it's because different repositories are involved.

@richardlau
ansible: update cache after adding NodeSource repo
bfd7407 
After adding the NodeSource repository for Node.js, set `update_cache`
on the subsequent "Install node" `package` task to run the equivalent
of `apt-get update` to fetch the package metadata from the newly added
repository.
@richardlau
Copy link
Member

richardlau commented Jan 7, 2021 •
edited
Loading

Pushed a commit to do the equivalent of apt-get update before installing the nodejs package.

The jenkins-workspace role is currently given to the following hosts that will need updating:

  • test-packetnet-ubuntu1804-x64-1
  • test-packetnet-ubuntu1804-x64-2
  • test-ibm-ubuntu1804-x64-1

@richardlau
Copy link
Member

Test build https://ci.nodejs.org/job/node-test-linter/38634/ (rebuild of https://ci.nodejs.org/job/node-test-linter/38339) appears to have passed.

@rvagg
Copy link
Member

rvagg commented Jan 7, 2021

did it remove the 12.x repo whle it was there? my guess is that just changing that line is going to add the new one but not do anything with the old. I'm not sure there's a good way of handling that without doing it manually or adding the 14.x as a new task and setting the 12.x one as absent.

@richardlau
Copy link
Member

No it did not. I'll add another task to manually remove the 12.x one.

@richardlau richardlau merged commit 7b51118 into nodejs:master Feb 15, 2021
@ExE-Boss ExE-Boss mentioned this pull request Feb 15, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@AshCripps AshCripps AshCripps approved these changes

Assignees
No one assigned
Labels
ansible ci-public
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade Node.js version on node-test-linter job
4 participants
@aduh95 @richardlau @rvagg @AshCripps