Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

www: dist-perms cron.daily script to fix ~dist permissions #2020

Merged
merged 1 commit into from
Nov 5, 2019

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Oct 31, 2019

After 5 days change ownership of downloadable resources to root, this locks them down and they can't be modified in any way by releasers. I'd like to change this to a shorter window but will wait till after Node 8 is EOL since Node 8 still has a Raspberry Pi builder so has reasonable delays in getting all assets promoted.

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rvagg rvagg merged commit e3a4a86 into master Nov 5, 2019
@rvagg rvagg deleted the rvagg/www-dist-perms branch November 5, 2019 10:27
@targos
Copy link
Member

targos commented Nov 5, 2019

I think this broke the release process.

I have the following error when I try to promote v13.1.0:

mkdir: cannot create directory ‘/home/dist/nodejs/release/v13.1.0’: Permission denied

/home/dist/nodejs/release belongs to root.

@rvagg
Copy link
Member Author

rvagg commented Nov 6, 2019

Fixed @ #2031, live on the server now, very sorry for the inconvenience @targos!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants