Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jenkins: use ccache with devtoolset on ppc64le #1927

Merged
merged 2 commits into from
Sep 30, 2019
Merged

jenkins: use ccache with devtoolset on ppc64le #1927

merged 2 commits into from
Sep 30, 2019

Conversation

sam-github
Copy link
Contributor

Because devtoolset setup works by putting the devtoolset bin/ on the
front of PATH the compiler is called directly instead of via the ccache
wrappers.

Change select-compiler.sh to explicitly use ccache, as it does for s390x.

@sam-github
Copy link
Contributor Author

It doesn't look like ubuntu was using ccache either for ppc64le

Because devtoolset setup works by putting the devtoolset bin/ on the
front of PATH the compiler is called directly instead of via the ccache
wrappers.

Change select-compiler.sh to explicitly use ccache, as it does for s390x.
ccache doesn't have wrappers for gcc-6,g++-4, etc., so call ccache
explicitly.
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sam-github sam-github merged commit c105ccc into nodejs:master Sep 30, 2019
@sam-github sam-github deleted the ccache-devtoolset-ppc64le branch September 30, 2019 21:52
@sam-github sam-github mentioned this pull request Oct 1, 2019
@sam-github
Copy link
Contributor Author

I reverted this, it broke node-test-commit-v8-linux: #1940 (comment)

I'll come back to it when I have time.

@richardlau
Copy link
Member

It doesn't look like ubuntu was using ccache either for ppc64le

I found out via nodejs/node#31628 that it was by virtue of ccache symbolic links.

richardlau added a commit to richardlau/node-1 that referenced this pull request Feb 7, 2020
Refactor `tools/make-v8.sh` to minimise differences between the
`ppc64le` and `s390x` paths to allow us to enable `ccache` on the
`ppc64le` machines in the CI.

PR-URL: nodejs#31628
Refs: nodejs/build#1927
Refs: nodejs/build#1940
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
codebytere pushed a commit to nodejs/node that referenced this pull request Feb 17, 2020
Refactor `tools/make-v8.sh` to minimise differences between the
`ppc64le` and `s390x` paths to allow us to enable `ccache` on the
`ppc64le` machines in the CI.

PR-URL: #31628
Refs: nodejs/build#1927
Refs: nodejs/build#1940
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
BethGriggs pushed a commit to nodejs/node that referenced this pull request Feb 26, 2020
Refactor `tools/make-v8.sh` to minimise differences between the
`ppc64le` and `s390x` paths to allow us to enable `ccache` on the
`ppc64le` machines in the CI.

PR-URL: #31628
Refs: nodejs/build#1927
Refs: nodejs/build#1940
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
BethGriggs pushed a commit to nodejs/node that referenced this pull request Mar 2, 2020
Refactor `tools/make-v8.sh` to minimise differences between the
`ppc64le` and `s390x` paths to allow us to enable `ccache` on the
`ppc64le` machines in the CI.

PR-URL: #31628
Refs: nodejs/build#1927
Refs: nodejs/build#1940
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants