Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup: remove osx #1356

Merged
merged 2 commits into from
Jun 19, 2018
Merged

setup: remove osx #1356

merged 2 commits into from
Jun 19, 2018

Conversation

maclover7
Copy link
Contributor

cc @gdams

gdams

This comment was marked as off-topic.

@maclover7
Copy link
Contributor Author

@gdams See #1357

@maclover7
Copy link
Contributor Author

Actually, wait, yeah that probably won't cut it. Let me add to doc/jenkins-guide.md...

@gdams
Copy link
Member

gdams commented Jun 18, 2018

yeah we should add it somewhere convinent for people to easily look it up

@maclover7
Copy link
Contributor Author

@gdams updated

gdams

This comment was marked as off-topic.

@mhdawson
Copy link
Member

I'm wondering if the non-MacStadium OSX machines (those I think that are in @rvagg's site) still need some of the parts being removed. @rvagg can you comment.

@rvagg
Copy link
Member

rvagg commented Jun 19, 2018

No, I think we're good to go with this. I believe I should be able to re-use the new Ansible scripts to re-setup the existing VMs if I dared blow away the existing state.

lgtm

mhdawson

This comment was marked as off-topic.

@maclover7 maclover7 merged commit b804f76 into nodejs:master Jun 19, 2018
@maclover7 maclover7 deleted the jm-rm-osx branch June 19, 2018 22:04
@maclover7
Copy link
Contributor Author

Landed in b804f76

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants