-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Action plan for 16.x upgrades #2445
Comments
From #2423, so far there's agreement that we need to get to at least devtoolset-7 for all the Linux platforms. V8 will force this on us. If we can get to a later one then even better but this is probably going to be dictated by IBM folks. |
We would like to go to devtoolset-8 (GCC8) - A lot of our systems already have that available and ones we have in the pipleline are targeting 8 aswell. |
We don't release on it, but we still test on smartos -- I assume we'll need to update those too? |
ah I forgot to mention feel free to update the list as I knew I wouldve forgotten something - Ill add smartos now |
yeah, and we should also look at what we should retire when we do these, we often don't clean up old combos as we move forward. |
@rvagg 100% agree if we get on top of this early enough we can clear a lot of cruft from the buildfarm especially with 10.x going EOL roughly around the same time. |
i think we don't need more talking, many and many os already have newer toolchain that nodejs need. so please quickly upgrade. i need many modern C++ syntax (for example: smart pointer) to write nodejs, i think if so, nodejs source code can be decreased very much and lighter. can we go further? action plan for 15.x, not wait 16.x. |
@anlexN Unfortunatly we can't push the update to 15.x as not all the platforms we support have GCC8 compatability and won't have it until near 16.x's release date. Also V8 won't require c++17 support until mid 2021 - https://chromium.googlesource.com/chromium/src/+/master/styleguide/c++/c++.md#modern-c_features |
but at least, we must remove python 2. it is died. |
With nodejs/node#37677 landing - AIX will be up to date and running GCC8 on master. IBMi has GCC10 coming but as its only running on daily jobs and not regular test runs it should be fine to wait - same with z/OS. The Linux on P and Z machines already run devtoolset-8 so from the RH/IBM side we should be in the clear. from a little poking around on the other platforms -
We also need to update configure.py in core to warn on anything below GCC8 and update the rest of the docs in core |
@rvagg are you going to be able to do the cross compilation updates? |
this has completely exited my mental stack - what's the requirement here, gcc8 all-round? this is a hard requirement going in to 16.x because of future upgrades, or actual code problem today? I think I got an initial gcc8 cross for armv7 prepared, but I'd need to revisit that, it would have been quite a while ago. |
@rvagg I think we are future proofing as c++17 features are coming in V8 later this year IIRC |
PR-URL: #37677 Refs: nodejs/build#2445 Reviewed-By: Stewart X Addison <sxa@redhat.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
The last version of Xcode 10 was released in 2019. Refs: nodejs/build#2445
nodejs/node#37871 updates the GCC requirement to 8.3 |
Refs: nodejs/build#2445 PR-URL: #37871 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Ash Cripps <acripps@redhat.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
The last version of Xcode 10 was released in 2019. Refs: nodejs/build#2445 PR-URL: #37872 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Ash Cripps <acripps@redhat.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Michael Dawson <midawson@redhat.com>
Need to test the next nightly but I think |
* ansible: add gcc-8 to Ubuntu 18.04 hosts/containers Baseline gcc/g++ compiler version for Node.js 16 and above is 8. The default `gcc` and `g++` packages on Ubuntu 18.04 install version 7. Moves `gcc*` and `g++*` out of the common `ubuntu` packages into `ubuntu1604`. Update `select-compiler.sh` to select GCC 8 for Node.js 16 and later, otherwise use GCC 6. Refs: #2445
This issue is the tracker for the updates and upgrades we need to undertake before the release date of 16.x in April 2021.
Toolchain updates
These machines will need the new versions installed and added to the ansible scripts
Scripts
Known Issues/Blockers
The text was updated successfully, but these errors were encountered: