-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Universal Base Image (UBI) build to CI system #2176
Comments
Nice! Do you have time to set up a preliminary version of a Dockerfile for this? See the Dockerfiles in here: https://github.com/nodejs/build/tree/master/ansible/roles/docker/templates, the one that it might be close to is ubuntu1804_sharedlibs.Dockerfile.j2 where we previously had FIPS tests running. Basically the image needs to be set up so that a Node repo can be mounted and compiled, the environment variables tell it where to link. Might not be needed for this image though if it's the default openssl installed I suppose. Do you know if you can |
@rvagg I’ll take a look at this. |
From my preliminary experiments it appears that you can. I've currently got a local dockerfile built based on UBI 8.1 and am currently building Node.js inside of it. Some notes:
this appears to want root. |
Sorry, about the late reply (I forgot that I had an email filter set up). This is to enable other test to pass which would not otherwise if the security policy was set to |
@danbev
node-test-commit-linux-containered has been extended to build on them for Node.js >= 13. e.g. this build is against current |
@richardlau Very nice 🎉 Thank you very much for setting this up! |
Description
This issue purposes adding a build for Universal Base Image (UBI) 8.1, which is based on RHEL, to the CI system.
Motivation
The motivation for doing this is that UBI 8.1 contains a system OpenSSL version that has FIPS support and this build would be configured to dynamically link to that OpenSSL version. This would allow us to exercise the FIPS code path which is currently not done. This is not something that happens often but there has been one occasion where code was committed to master which failed to compiler when fips was enabled: nodejs/node@17d87d5
Docker build instructions
Currently there is one test failure which is covered by nodejs/node#31715
The text was updated successfully, but these errors were encountered: