-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
temporary access to build machines for thefourtheye #1775
Comments
@thefourtheye as a TSC member I don't think it'll be too controversial to just give you "test" access to our infra which should give you everything you need, there's a few others in this category already. You'll just need to be aware that:
I'll need to put a gpg key for you into https://github.com/nodejs-private/secrets so you can read build/test where our test ssh key is and some more instructions, so get me a public gpg key I can put in. You'll also need to either read ansible/inventory.yml and use those user@ip combinations directly or use write-config.yml (see https://github.com/nodejs/build/tree/master/ansible#playbooks) to set up your .ssh/config. If anyone objects to going this route, please speak up! |
Thanks @rvagg for the instructions and guidelines. I'll generate a GPG key and share here. |
I am highly supportive of this effort related to #1674 (comment). |
+1 |
1 similar comment
+1 |
Any update here? |
I had a few questions, so I checked with @rvagg last week. I have shared my public key with him today. |
@thefourtheye I've added your gpg key to our secrets repo, see the readme there for instructions on how to get access to the resources. Review my comments to Sam when I added him last week, that's a good start: #1787 You'll probably want to get your .ssh/config set up. As per the ansible/README.md, on the |
|
@gireeshpunathil, @sam-github could you look at how we get Python 3 onto the AIX machines and pull me in for context on what we did for other packages. I think it's best that we help out on that front. |
@thefourtheye we've not used smitty in the past on AIX for adding modules. I think it would be best if @sam-github helped out on this front. |
bull freeware is where we have pulled packages in the past, this is the first place to look: http://www.bullfreeware.com/search.php?package=python3. It is pretty tricky though (AIX 7.1 is much better) so I'd prefer if we do it on one machine to start. |
https://www.python.org/download/other might be worth looking at also. (Or if it is out of date, contributing back to.) |
I managed to compile the list of all the loginable machines with the |
Are we agreed that:
If we install or upgrade a machine’s Python 3, then we will also upgrade its Python 2 if required. Perhaps we need a fill color version of the spreadsheet: |
As per Python's support information for different versions (which can be found here),
I agree to all the three points. As discussed over Slack, I gave write access to the document to you. |
|
I see 3 problems: 1) freebsd11 machine is dead, not a surprise, it happens occasionally (freebsd rage post omitted), I'll address that. 2) the odroid c2 machines are no longer in use, they should have been removed from the inventory but obviously I missed that step. 3) something weird's up with your access to the macos machines. They use a separate port for SSH access, are you using it from your .ssh/config or manually connecting? I'm not sure what else this could be other than missing port on SSH but I'll have a look when I'm back at a computer (phone posting this one). |
Oh, and you can ignore some of the other machines too: centos5 should be removed from our infra. iirc it was redundant with node 4. Some of the other ones will be redundant with node 6 retiring I think and maybe we can skip them entirely anyway if we're not going to bother "fixing" node 8, and node 10? If we only want full python 3 support then the list of machines is much smaller. Centos6, ubuntu14 and some others all go away. |
I'm spelunking into the ansible files to see if I can figure out how python is installed on AIX. Finding anything in ansible is a nightmare, but I'll do my best. If I can figure that out, I'll see if I can find a python3 equivalent. |
Are these three Ubuntu ansible docker files of interest? #1679 |
I installed python3 on Also, I didn't use the documented steps exactly, because I don't have permissions to upload the archive to ci.nodejs.org/downloads, I just downloaded it directly.
|
https://ci.nodejs.org/computer/test-osuosl-aix61-ppc64_be-2/builds <--- builds look fine, installing python3 on the other two test machines. |
I've forced a restart of the freebsd11 machine and it's still not letting me in, it might be reprovision time for that one macstadium is odd now that I'm looking at it, I can't get in either so there's something up with our setup there, I'll open a new issue for that |
test-digitalocean-freebsd11-x64-1 is back up again |
Thanks @rvagg. I updated the status of
I tried connecting with
I am able to
But
Thank you :-) |
See #1810 (comment) it was just an issue with the specific machine (and one other) that you tried to ssh to. They are behind a host that forwards on to the actual machines. I just as the required port to my ssh config file and all works fine |
@mhdawson Can you please tell us what happens when you do “brew info python” on one or more of these macOS machines? If homebrew is installed on them then these upgrades should be quite straightforward: https://docs.python-guide.org/starting/install3/osx/ |
Changes to these machines are going to need to go through ansible rather than just being manual, so we maintain repeatability. It looks like brew is all set up in our Ansible configs so maybe a section in roles/baselayout/vars/main.yml for 'macos' to do the work is the way to go? @nodejs/build anyone with access want to give this a go? |
Here's a full output ftr, it's not consistent:
|
brew install python or brew install python@2 should force a brew update/upgrade to happen before the Python install so my bet is that all the boxes would end up with the same Python version(s). |
Is the list at the top of this PR up-to-date? |
update on the state of macos is in #1836, it's taken a few days to wrangle it under control but it seems to be all consistent now with both versions installed but we need to be explicitly referencing |
Is the status table at the top of this issue up to date? I am having trouble understanding our progression and #1802 which would have allowed shared editing of such a table is also not progressing. We need an up-to-date status table. Our only repos that have known (lintable) Python 3 incompatibilities are: nodejs/ffi, nodejs/nan, nodejs/node-auto-test, nodejs/node-chakracore, nodejs/perfetto-nodejs-wip, nodejs/worker. Please let me know if any of these repos are mission critical so that I can focus on them. If not, then now is the time for us to start testing in earnest Python 3. With 188 days left until Python 2 end of life, I would like us to be pushing hard to be ready. Your thoughts on how we can accelerate? |
@thefourtheye ping re status, can you help us move forward here? @cclauss re the list of repos, none are critical path. |
This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made. |
We should probably remove the temporary access at this point unless @thefourtheye chimes in to let us know they're still working on this. |
I've gone ahead and removed the gpg key for @thefourtheye. We can add him back if needed. |
In order to have our Node.js core build system compatible with Python 2 and Python 3, we need to have both of them in our build machines as the first step.
We are trying to figure out a way to install Python3 in all our build machines. Few of our supported platforms do not have Python 3 in their respective package management systems. To figure out how to install it, I would like to have temporary access to our build machines.
PS: I tried local VMs to do this, but it is very time consuming and I don't have enough resources in my machine.
cc @nodejs/build @refack @cclauss
List of machines which need Python 3 or attention
yum search python3
failed withM2Crypto.SSL.SSLError: tlsv1 alert protocol version
apt-get -s install python3
shows python3.2 is availableapt-get -s install python3
shows python3.2 is availablepkgin av | grep -i python3
shows both 3.3 and 3.4 are availablepkgin av | grep -i python3
shows both 3.3 and 3.4 are availablepkgin av | grep -i python3
shows both 3.3 and 3.4 are availablepkgin av | grep -i python3
shows both 3.3 and 3.4 are availablepkgin av | grep -i python3
shows 3.3, 3.4, and 3.5 are availablepkgin av | grep -i python3
shows 3.3, 3.4, and 3.5 are availablepkgin av | grep -i python3
shows 3.3, 3.4, and 3.5 are availablepkgin av | grep -i python3
shows 3.3, 3.4, and 3.5 are availablepkgin av | grep -i python3
shows 3.4, 3.5, and 3.6 are availablepkgin av | grep -i python3
shows 3.4, 3.5, and 3.6 are availablesmitty
smitty
smitty
yum search python3
shows Python 36yum search python3
shows Python 36yum search python3
shows Python 36apt-cache search python3
shows Python 3.2 Debug buildyum search python3
does not have anythingyum search python3
does not have anythingyum search python3
shows Python 36yum search python3
shows Python 36yum search python3
shows Python 36Notes:
centos-release-6-10.el6.centos.12.3.x86_64
rpm -q centos-release
(Find OS version)yum install centos-release-scl
2.
yum install rh-python36
The text was updated successfully, but these errors were encountered: