Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NODE_EXTERN napi_value napi_run_script(napi_env e, const char *script); #51

Closed
gabrielschulhof opened this issue Jan 20, 2017 · 2 comments
Closed

NODE_EXTERN napi_value napi_run_script(napi_env e, const char *script); #51

gabrielschulhof opened this issue Jan 20, 2017 · 2 comments
Assignees
@boingoing

Comments

@gabrielschulhof
Copy link
Collaborator

I realized from #33 (comment) that we may want to have such an API because AFAIK all engines provide this functionality.
@aruneshchandra aruneshchandra added this to the Milestone 5 milestone Feb 3, 2017
@aruneshchandra aruneshchandra removed this from the Milestone 5 milestone Feb 23, 2017
@boingoing boingoing removed this from the Milestone 6 (PR Submission) milestone Mar 10, 2017
@jasongin jasongin mentioned this issue Jun 1, 2017
Closed
@mhdawson
Copy link
Member

mhdawson commented Jun 26, 2017 •
edited
Loading

Have we seen any modules need to do it ? Thinking we should keep the api surface small, so unless we have examples where modules are using eval we might want to leave it out for now.

@jasongin jasongin mentioned this issue Jul 18, 2017
Closed
This was referenced Sep 6, 2017
Closed
Closed
@gabrielschulhof
Copy link
Collaborator Author

@levimm has use for such an API.

@gabrielschulhof gabrielschulhof mentioned this issue Sep 6, 2017
Closed
4 tasks
gabrielschulhof pushed a commit to gabrielschulhof/node that referenced this issue Sep 6, 2017
n-api: implement napi_run_script
ca0d064 
Fixes: nodejs/abi-stable-node#51
PR-URL: nodejs#15216
MylesBorins pushed a commit to nodejs/node that referenced this issue Sep 10, 2017
@MylesBorins
n-api: implement napi_run_script
f9a5017 
Fixes: nodejs/abi-stable-node#51
PR-URL: #15216
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com
Reviewed-By: James M Snell <jasnell.gmail.com>
Reviewed-By: Michael Dawson <mhdawson@ca.ibm.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
MylesBorins pushed a commit to nodejs/node that referenced this issue Sep 11, 2017
@MylesBorins
n-api: implement napi_run_script
342d526 
Fixes: nodejs/abi-stable-node#51
PR-URL: #15216
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com
Reviewed-By: James M Snell <jasnell.gmail.com>
Reviewed-By: Michael Dawson <mhdawson@ca.ibm.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
MylesBorins pushed a commit to nodejs/node that referenced this issue Sep 12, 2017
@MylesBorins
n-api: implement napi_run_script
4bf0d4e 
Fixes: nodejs/abi-stable-node#51
PR-URL: #15216
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com
Reviewed-By: James M Snell <jasnell.gmail.com>
Reviewed-By: Michael Dawson <mhdawson@ca.ibm.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
addaleax pushed a commit to addaleax/node that referenced this issue Sep 13, 2017
@addaleax
n-api: implement napi_run_script
8351947 
Fixes: nodejs/abi-stable-node#51
PR-URL: nodejs#15216
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com
Reviewed-By: James M Snell <jasnell.gmail.com>
Reviewed-By: Michael Dawson <mhdawson@ca.ibm.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
gabrielschulhof pushed a commit to gabrielschulhof/node that referenced this issue Apr 10, 2018
n-api: implement napi_run_script
32504e1 
Fixes: nodejs/abi-stable-node#51
PR-URL: nodejs#15216
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com
Reviewed-By: James M Snell <jasnell.gmail.com>
Reviewed-By: Michael Dawson <mhdawson@ca.ibm.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
MylesBorins pushed a commit to nodejs/node that referenced this issue Apr 16, 2018
@MylesBorins
n-api: implement napi_run_script
3b4708b 
Fixes: nodejs/abi-stable-node#51
Backport-PR-URL: #19447
PR-URL: #15216
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com
Reviewed-By: James M Snell <jasnell.gmail.com>
Reviewed-By: Michael Dawson <mhdawson@ca.ibm.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@boingoing boingoing

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

n-api: implement napi_run_script gabrielschulhof/node
4 participants
@gabrielschulhof @boingoing @mhdawson @aruneshchandra