Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Title inconsistent with actual function signature in the doc #243

Closed
legenddcr opened this issue May 16, 2017 · 1 comment
Closed

Title inconsistent with actual function signature in the doc #243

legenddcr opened this issue May 16, 2017 · 1 comment

Comments

@legenddcr
Copy link

Two URL:

"napi_get_value_string_utf16_length" in title should be "napi_get_value_string_utf16".
@mhdawson
Copy link
Member

Thanks will fix that up

mhdawson added a commit to mhdawson/io.js that referenced this issue May 19, 2017
@mhdawson
doc: fix title/function name mismatch
1ad77df 
Fix mismatch in title for napi_get_value_string_utf16

Fixes: nodejs/abi-stable-node#243
@mhdawson mhdawson mentioned this issue May 19, 2017
Closed
3 tasks
jasnell pushed a commit to nodejs/node that referenced this issue May 24, 2017
@mhdawson @jasnell
doc: fix title/function name mismatch
a9b78b2 
Fix mismatch in title for napi_get_value_string_utf16

Fixes: nodejs/abi-stable-node#243
PR-URL: #13123
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
jasnell pushed a commit to nodejs/node that referenced this issue May 28, 2017
@mhdawson @jasnell
doc: fix title/function name mismatch
336d33b 
Fix mismatch in title for napi_get_value_string_utf16

Fixes: nodejs/abi-stable-node#243
PR-URL: #13123
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
gabrielschulhof pushed a commit to gabrielschulhof/node that referenced this issue Apr 10, 2018
@mhdawson
doc: fix title/function name mismatch
2e48f58 
Fix mismatch in title for napi_get_value_string_utf16

Fixes: nodejs/abi-stable-node#243
PR-URL: nodejs#13123
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit to nodejs/node that referenced this issue Apr 16, 2018
@mhdawson @MylesBorins
doc: fix title/function name mismatch
2e29052 
Fix mismatch in title for napi_get_value_string_utf16

Fixes: nodejs/abi-stable-node#243
Backport-PR-URL: #19447
PR-URL: #13123
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@legenddcr @mhdawson