Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: sync Security-Team.md GitHub teams membership #897

Merged
merged 1 commit into from
Sep 18, 2020

Conversation

richardlau
Copy link
Member

Results of running ncu-team sync Security-Team.md from
node-core-utils.

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

- [@shigeki](https://github.com/shigeki) - Shigeki Ohtsu
- [@vdeturckheim](https://github.com/vdeturckheim) - Vladimir de Turckheim
- [@watson](https://github.com/watson) - Thomas Watson
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@watson has access to h1 and node-private

Copy link
Member Author

@richardlau richardlau Jul 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but is not in https://github.com/orgs/nodejs/teams/security-triage/members which is what this list syncs with. He's still listed as having access in the other two lists in this document.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think @watson has as much time as he'd hoped to get involved on this front. @watson should you be added to the https://github.com/orgs/nodejs/teams/security-triage/members?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, it was my intend be have been more involved, but I've been overloaded for a while so it hasn't been possible. However, I would still like to be part of the team if possible.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@richardlau I've added @watson to the list you mentioned so you should be able to re-run the sync and get this landed

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-synced. @mcollina PTAL.

@richardlau
Copy link
Member Author

We might need to sync again after nodejs/node#34809?

@mhdawson
Copy link
Member

@richardlau can you resync again and then we'll try to get it landed. @mcollina I assume you can remove your objetion as it was updated?

Results of running `ncu-team sync Security-Team.md` from
node-core-utils.
@richardlau
Copy link
Member Author

Resynced.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mhdawson mhdawson merged commit 00d8620 into nodejs:master Sep 18, 2020
@richardlau richardlau deleted the security branch September 18, 2020 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants