Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nit: update statement about OpenSSL and Node.js 10.x #1007

Closed
wants to merge 2 commits into from

Conversation

brody4hire
Copy link

No description provided.

@brody4hire brody4hire changed the title update statement about OpenSSL and Node.js 10.x nit: update statement about OpenSSL and Node.js 10.x Mar 31, 2021
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with or without semicolon and with or without "but".

Co-authored-by: Rich Trott <rtrott@gmail.com>
danbev pushed a commit that referenced this pull request Apr 8, 2021
PR-URL: #1007
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Co-authored-by: Rich Trott <rtrott@gmail.com>
@danbev
Copy link
Contributor

danbev commented Apr 8, 2021

Landed in 5a5963a.

@danbev danbev closed this Apr 8, 2021
@brody4hire brody4hire deleted the patch-1 branch April 8, 2021 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants