Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Developer's Certificate of Origin version #92

Closed
williamkapke opened this issue Apr 18, 2016 · 7 comments
Closed

Developer's Certificate of Origin version #92

williamkapke opened this issue Apr 18, 2016 · 7 comments

Comments

@williamkapke
Copy link
Contributor

williamkapke commented Apr 18, 2016

Several Working Groups have a reference to Developer's Certificate of Origin 1.0 however nodejs/node#5170 makes me think maybe these should be updated to v 1.1.

Since WGs are autonomous I guess they're not forced to use v1.1, but I bet many just don't know of the newer version- or that the older one is used in their documentation. I can do PRs for all of these, but before I do- I'm wondering if this is one of those rare things that the lawyers insist WGs adopt. If so, should these just have a URL pointing to a "Master" Developer's Certificate of Origin that applies to all things under the Node.js Foundation?

Using DCO v1.1

https://github.com/nodejs/node/blob/master/CONTRIBUTING.md
https://github.com/nodejs/node-chakracore/blob/master/CONTRIBUTING.md
https://github.com/nodejs/docs/blob/master/CONTRIBUTING.md

Using DCO v1.0

https://github.com/nodejs/Intl/blob/master/CONTRIBUTING-draft.md
https://github.com/nodejs/TSC/blob/master/Applications/Express.md
https://github.com/nodejs/TSC/blob/master/BasePolicies/Governance.md
https://github.com/nodejs/TSC/blob/master/Project-Lifecycle.md
https://github.com/nodejs/TSC/blob/master/WORKING_GROUPS.md
https://github.com/nodejs/benchmarking/blob/master/CONTRIBUTING.md
https://github.com/nodejs/dev-policy/blob/master/README.md
https://github.com/nodejs/docker-iojs/blob/master/GOVERNANCE.md
https://github.com/nodejs/docker-node/blob/master/GOVERNANCE.md
https://github.com/nodejs/evangelism/blob/master/CONTRIBUTING.md
https://github.com/nodejs/hardware/blob/master/CONTRIBUTING.md
https://github.com/nodejs/iojs.org/blob/master/CONTRIBUTING.md
https://github.com/nodejs/nan/blob/master/README.md
https://github.com/nodejs/node-chakracore/blob/master/WORKING_GROUPS.md
https://github.com/nodejs/node/blob/master/WORKING_GROUPS.md
https://github.com/nodejs/nodejs-hu/blob/master/content/en/working-groups.md
https://github.com/nodejs/nodejs-uk/blob/master/CONTRIBUTING.md
https://github.com/nodejs/nodejs.org/blob/master/COLLABORATOR_GUIDE.md
https://github.com/nodejs/post-mortem/blob/master/CONTRIBUTING.md
https://github.com/nodejs/testing/blob/master/Governance.md

https://github.com/nodejs/inclusivity-slack-inviter/blob/master/CONTRIBUTING.md

https://github.com/nodejs/inclusivity/blob/master/CONTRIBUTING.md

legacy repos...

https://github.com/nodejs/iojs.org/blob/master/content/en/working-groups.md
https://github.com/nodejs/iojs.org/blob/master/content/tr/working-groups.md
https://github.com/nodejs/node-convergence-archive/blob/master/CONTRIBUTING.md
https://github.com/nodejs/node-convergence-archive/blob/master/WORKING_GROUPS.md

@mikeal
Copy link
Contributor

mikeal commented Apr 18, 2016

We should update across the board to 1.1

@mhdawson
Copy link
Member

mhdawson commented Apr 21, 2016

In the case of the benchmarking and post-mortem WG it's simply a case of did not know. What's there was derived from what was in place when the WG formed. The only questions I have are :

  • if we change do we need to actively alert WG members
  • do we need to know what was contributed under one versus the other or is simply knowing the change over date/timestamps commits enough ?

@williamkapke
Copy link
Contributor Author

it's simply a case of did not know. What's there was derived from what was in place when the WG formed.

@mhdawson I'm certain that is the case for all of them and I think you raise some good questions. Hopefully the TSC give some guidance.

@williamkapke
Copy link
Contributor Author

@mhdawson Did you get answers to your questions above from any @nodejs/tsc reps?
(Looking to help move nodejs/benchmarking#46 forward)

julianduque pushed a commit to nodejs/evangelism that referenced this issue May 20, 2016
mhdawson pushed a commit to nodejs/benchmarking that referenced this issue Jun 8, 2016
See: nodejs/TSC#92

PR-URL: #46
Reviewed-by: Michael Dawson <michael_dawson@ca.ibm.com>
@williamkapke
Copy link
Contributor Author

Ok, so there is only 1 of these left in the entire org: nodejs/dev-policy#78. @jasnell - you have 99% of the commits on that repo, are you the only person with access to the Merge button? Can I get you to merge it so I can close out this issue?

@Fishrock123
Copy link
Contributor

@williamkapke merged

@williamkapke
Copy link
Contributor Author

🎉 thanks @Fishrock123 !

dreamhigh0525 pushed a commit to dreamhigh0525/dev-policy that referenced this issue Mar 9, 2023
rluvaton pushed a commit to nodejs/performance that referenced this issue Apr 8, 2024
See: nodejs/TSC#92

PR-URL: nodejs/benchmarking#46
Reviewed-by: Michael Dawson <michael_dawson@ca.ibm.com>
amitparida added a commit to amitparida/npm-nan that referenced this issue Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants