-
Notifications
You must be signed in to change notification settings - Fork 568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backporting Release key README changes to nodejs/node version branches #595
Comments
Related nodejs/node#36835 |
For my particular case, I've cherry-picked the commit for my key onto Might be worth having a discussion anyway re. policy. https://github.com/nodejs/Release/blob/master/GOVERNANCE.md#adding-new-releasers doesn't currently mention anything about a release line needing to have the key in the README for that line before a releaser can sign a release on that line. |
We discussed this in the last release WG meeting, and the suggestion was to cherry-pick the keys (or any key updates) on to all of the active release branches. I will leave this open as a reminder to add a note to our docs. |
Awesome @BethGriggs! |
Now that we're backporting releaser's keys to all active release branches by default, it should be possible to extract the valid keys for a given release from the major release branch ( It should also be possible to extract the valid keys from the tagged version of the source, or from the source tarball download (e.g. https://github.com/nodejs/node/tree/v15.8.0#release-keys or https://nodejs.org/download/release/latest-v15.x/node-v15.8.0.tar.gz). |
docker-node now has a script for pulling the keys from README with https://github.com/nodejs/docker-node/blob/master/update-keys.sh
I noticed that the README changes for adding the release keys doesn't appear to be backported to the branches for @richardlau addition. If the branches are kept in sync, they could be specific to the release line over in docker-node as well.
The text was updated successfully, but these errors were encountered: