Move validation messages to each reference #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #396 +/- ##
==========================================
- Coverage 74.14% 74.09% -0.06%
==========================================
Files 9 9
Lines 882 880 -2
Branches 233 233
==========================================
- Hits 654 652 -2
Misses 135 135
Partials 93 93
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validation errors were class-wide making it unnecessarily difficult to match an error with the reference that caused it. This PR moves those errors to the
referenceon which they occurred.Additionally, the validation error for a
checkSignature()was changed to throw instead of adding to a globalvalidationErrorsobject.