Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure the X509Certificate tag is properly prefixed #377

Merged
merged 4 commits into from
Oct 7, 2023
Merged

Ensure the X509Certificate tag is properly prefixed #377

merged 4 commits into from
Oct 7, 2023

Conversation

casewalker
Copy link
Contributor

@casewalker casewalker commented Aug 14, 2023

Creating a signature using the default getKeyInfoContent function was missing prefixes on the X509Certificate tags, e.g.:

    ...
    <ds:KeyInfo>
        <ds:X509Data> 
            <X509Certificate>MII...</X509Certificate>
       </ds:X509Data>
    </ds:KeyInfo>
    ...

This PR should fix that. I modified an existing test to stop stubbing out the default getKeyInfoContent so that the existing behavior broke that test, then validated that the new behavior causes it to pass.

@casewalker casewalker changed the title Fix prefix on x509certificate Ensure the X509Certificate tag is properly prefixed Aug 14, 2023
@codecov
Copy link

codecov bot commented Oct 7, 2023

Codecov Report

Merging #377 (e1e19b4) into master (2aa2d13) will increase coverage by 0.11%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #377      +/-   ##
==========================================
+ Coverage   74.24%   74.35%   +0.11%     
==========================================
  Files           9        9              
  Lines         889      889              
  Branches      236      236              
==========================================
+ Hits          660      661       +1     
  Misses        135      135              
+ Partials       94       93       -1     
Files Coverage Δ
src/signed-xml.ts 77.08% <100.00%> (+0.23%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cjbarth cjbarth added the bug label Oct 7, 2023
@cjbarth cjbarth merged commit 073d4a6 into node-saml:master Oct 7, 2023
9 checks passed
@casewalker casewalker deleted the fix-prefix-on-x509certificate branch October 9, 2023 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants