Add method for checking if element is signed #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #368 +/- ##
==========================================
+ Coverage 72.38% 72.56% +0.17%
==========================================
Files 9 9
Lines 862 882 +20
Branches 229 234 +5
==========================================
+ Hits 624 640 +16
- Misses 138 151 +13
+ Partials 100 91 -9
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
LoneRifle
requested changes
Aug 1, 2023
LoneRifle
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current recommendation is to have consumers check IDs on elements. We already do this internally, with much more rigor than the README suggests. This PR adds a method to leverage internal methods to perform a more rigorous check of signing of elements the consumer would like to use.