Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce eslint no-unused-vars #349

Merged
merged 1 commit into from
Jul 21, 2023
Merged

Conversation

cjbarth
Copy link
Contributor

@cjbarth cjbarth commented Jul 20, 2023

No description provided.

@cjbarth cjbarth added the chore label Jul 20, 2023
@cjbarth
Copy link
Contributor Author

cjbarth commented Jul 20, 2023

@LoneRifle, this should the the last PR to clean up the code. If you agree that this is ready for a 4.0 release, please LMK and I'll do so, documenting the process for others to follow.

@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Merging #349 (3aa36fc) into master (3abd8eb) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #349   +/-   ##
=======================================
  Coverage   72.19%   72.19%           
=======================================
  Files           9        9           
  Lines         856      856           
  Branches      227      227           
=======================================
  Hits          618      618           
  Misses        137      137           
  Partials      101      101           
Impacted Files Coverage Δ
src/signed-xml.ts 74.18% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@LoneRifle LoneRifle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@cjbarth cjbarth merged commit a383c94 into node-saml:master Jul 21, 2023
9 checks passed
@cjbarth cjbarth deleted the eslint-no-unused branch July 21, 2023 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants