Force CI to run on every PR

[cjbarth]

To improve code quality going forward, this PR will enable all tests to run on every PR.

In order to get tests to most closely represent an actual deployment npm ci is used, this, however, isn't available on older versions of Node, so the test matrix doesn't reflect the actually supported versions of Node. We should do a semver-major change to get this version up to Node@8, at least, to be able to test all supported versions.

[LoneRifle]

Could you clarify what you mean by broken tests? I just did npm test on my local dev and on a gitpod instance using Node 16 as well as Node 4, and all the tests pass.

[cjbarth]

This is why we have code review :)

It turns out that nodeunit doesn't do globbing very well. Once I reverted the glob, all the tests started working. Sorry about that.

So, the only thing that this PR would do then is to make sure all tests run on every PR.

[LoneRifle]

Generally lgtm. Some concerns about the nature of the changes but non-blockers.

[shunkica]

It turns out that nodeunit doesn't do globbing very well. Once I reverted the glob, all the tests started working. Sorry about that.

Maybe this is an opportunity to move away from nodeunit as it is a dead project.

[cjbarth]

@shunkica , I'd love to see a PR that does that. We currently use Jasmine in the other projects here, so it would be reasonable to move to that for consistency. However, anything would be better than nodeunit at this point.

[cjbarth]

@shunkica , would you be willing to put up a PR for a migration of the tests?

[cjbarth]

@LoneRifle , I think I've addressed all your concerns. Feel free to have another look at this. Your feedback is quite good. I look forward implementing some of this over in node-saml and passport-saml.

[LoneRifle]

lgtm, as discussed. Thanks for looking into this!