Update signed-xml.js

[larspederamlie]

fix namespace issue, fixes #72

[LoneRifle]

I guess this is a commit that was cherry-picked from auth0/xml-crypto@25a3d1c . Thanks for bringing this up; I'll look into this and other commits that their fork has and try to reconcile the codebases

[larspederamlie]

Yes, that is correct. We're using samlify and got the same problem. This commit fixes the problem. Thanks LP

…

-------- Original message -------- From: LoneRifle <notifications@github.com> Date: 2/8/19 22:30 (GMT-05:00) To: yaronn/xml-crypto <xml-crypto@noreply.github.com> Cc: "Amlie, Lars Peder" <Lars.Peder.Amlie@dnvgl.com>, Author <author@noreply.github.com> Subject: Re: [yaronn/xml-crypto] Update signed-xml.js (#172) I guess this is a commit that was cherry-picked from auth0/xml-crypto@25a3d1c<auth0@25a3d1c> . Thanks for bringing this up; I'll look into this and other commits that their fork has and try to reconcile the codebases — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#172 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/Agsqm4WclPC8T6GXAn-CkX-p4jzwLVXEks5vLkC5gaJpZM4axNmP>. ************************************************************************************** This e-mail and any attachments thereto may contain confidential information and/or information protected by intellectual property rights for the exclusive attention of the intended addressees named above. If you have received this transmission in error, please immediately notify the sender by return e-mail and delete this message and its attachments. Unauthorized use, copying or further full or partial distribution of this e-mail or its contents is prohibited. **************************************************************************************

[larspederamlie]

Sure, no problem. Thanks LP From: LoneRifle <notifications@github.com> Sent: Saturday, February 9, 2019 7:13 PM To: yaronn/xml-crypto <xml-crypto@noreply.github.com> Cc: Amlie, Lars Peder <Lars.Peder.Amlie@dnvgl.com>; Author <author@noreply.github.com> Subject: Re: [yaronn/xml-crypto] Update signed-xml.js (#172) If it's okay with you, I will like to make a PR that merges the original commit from Auth0, which will mean that yours will be closed. I'm doing that largely to ensure that contributions from forks of this repo are accounted for when merged back here. I will give you credit for bringing this up, so hope that's okay with you. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#172 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/Agsqm4GsIXp_UnTK_bvEhhzdL3cYhddcks5vL2QIgaJpZM4axNmP>. ************************************************************************************** This e-mail and any attachments thereto may contain confidential information and/or information protected by intellectual property rights for the exclusive attention of the intended addressees named above. If you have received this transmission in error, please immediately notify the sender by return e-mail and delete this message and its attachments. Unauthorized use, copying or further full or partial distribution of this e-mail or its contents is prohibited. **************************************************************************************