Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecation notices for renamed variables #568

Merged
merged 3 commits into from
Mar 23, 2021
Merged

Conversation

cjbarth
Copy link
Collaborator

@cjbarth cjbarth commented Mar 19, 2021

This simply renames option names and adds deprecation notices to help people prepare for 3.x

  • disableRequestACSUrl -> disableRequestAcsUrl
  • RACComparison -> racComparison

@cjbarth cjbarth merged commit 8114d4c into node-saml:2.x Mar 23, 2021
@cjbarth cjbarth deleted the 2.x branch March 23, 2021 15:00
@cjbarth cjbarth mentioned this pull request May 10, 2021
@cjbarth cjbarth added the semver-minor This PR requires a semver-minor version bump label May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-minor This PR requires a semver-minor version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants