normalize signature line endings before loading signature block to xml-crypto

[mhassan1]

Description

Resolves #511

Checklist:

• Issue Addressed: [X]
• Link to SAML spec: [ ]
• Tests included? [X]
• Documentation updated? [ ]

[mhassan1]

@cjbarth Is there anything I can do to help get this merged? What is your expectation on a release timeline?

[cjbarth]

@mhassan1 We don't have a release timeline. It is nice when people can use the specific commit in their package.json to test the latest code. After a period of stability, we'll typically cut a release. @markstos has been doing a lot of the releases, and I like lots of eyes on security stuff, so Iet's wait for his thoughts on this matter.

[markstos]

This looks good to me. @cjbarth I'm fairly fair behind on my passport-saml mail at this point.

If you want to go ahead cut the next the release that's fine with me. I believe you have NPM publish rights.

[mhassan1]

@cjbarth Are you planning a new release? One problem with pointing to a specific commit is that the compiled JS is not checked in, so we would need to build the project ourselves.

[cjbarth]

Some recent changes that we made should cause a compilation when it is installed using a specific commit. Is that not working?

[mhassan1]

How should that work? Which recent change? We are using yarn v2, which will run a postinstall step, if it exists, but this package doesn't have one (and that's discouraged just for the purpose of compilation).

[mhassan1]

Oh, I see the prepare script. I would still rather point to an NPM dist if you are planning to cut a release in the next few days. Are you planning to? If not, please let me know so I can plan accordingly.