types: avoid ts-expect-error on generateServiceProviderMetadata #510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I vote for #508 as it does not alter the base class |
|
#508 is merged in master branch |
midgleyc
force-pushed
the
dont-expect-error-generateServiceProviderMetadata
branch
from
6d0e220 to
509e883
Compare
|
Sure, ignoring the error in the type file too works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In multiSamlStrategy, generateServiceProviderMetadata currently changes the signature from the base class, and uses a ts-expect-error so that compilation continues to work. However, the type files show errors because the subclass is no longer an instance of its base class.
This adds an overload to generateServiceProviderMetadata taking the original arguments and returning "never", while the implementation still checks the type of the callback to confirm we're using the right call.
Checklist: